esbuild: Add webp to the file endings loaded as files #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sort of related: I ran in to that recently but never got around to opening a PR… |
|
Thanks, @matiaskorhonen 👍 Added it, alongside AVIF and JPEG-XL. That would then complete the list of the image formats I have on my radar. |
|
Fantastic! |
|
Should this change have actually gone into |
|
I think you're right, @matiaskorhonen . PR is here: #870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
This PR adds a few file extensions as a file type to the list in
esbuild.defaults.js:.jpeg.avif.jxl.webpWith this change, WebP, AVIF and JPEG-XL images are supported in the same way that PNG and JPEG are supported. It also adds
.jpegas the alternative file extension for JPEG files.Context
This is from a discussion about me failing to fingerprint images